ELFA/database-apps
15
0
Fork 0
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity

Use shared upstream saved-view tabs in the native table port #85

Merged
michielbdejong merged 1 commit from codex/table-view-tabs into main 2026-11-06 12:14:02 +01:00
Conversation 0 Commits 1 Files changed 6 +80 -33
michielbdejong commented 2026-11-06 10:24:40 +01:00
Owner
Copy link

Stacked on #84 to keep this review focused on the saved-view increment. Uses upstream AtomicServer #2453, which builds on the original package extraction (#2434).

Replace the saved-view dropdown with the same tab presentation used by AtomicServer's TablePage. Double-click the active saved tab to rename it; Enter or blur stages the name and Escape cancels. Existing explicit Save/Discard behavior, collection isolation, deep links, native metadata storage and conflict detection remain owned by the NextGraph adapter. The View name field remains available for keyboard access and creating views.

Pin the submodule to the shared component commit and update setup/provenance documentation. View-type/app/filter menus and drag ordering remain in the Atomic host; this does not claim full TablePage parity.

Validation: all 10 native port browser tests, 5 view/draft unit tests, port typecheck and production build passed. The upstream package passed 16 tests, its typecheck and clean packed-consumer runtime/NodeNext checks; the Data Browser passed its 3 existing tab/menu tests, typecheck and required workspace lint. Desktop/mobile screenshots were captured and shared in the implementation chat.

After checking out this branch: run pnpm setup:table, then pnpm install --force --frozen-lockfile to refresh the local package snapshot.

Stacked on #84 to keep this review focused on the saved-view increment. Uses upstream [AtomicServer #2453](https://github.com/ontola/atomic-server/pull/2453), which builds on the original package extraction (#2434). Replace the saved-view dropdown with the same tab presentation used by AtomicServer's TablePage. Double-click the active saved tab to rename it; Enter or blur stages the name and Escape cancels. Existing explicit Save/Discard behavior, collection isolation, deep links, native metadata storage and conflict detection remain owned by the NextGraph adapter. The View name field remains available for keyboard access and creating views. Pin the submodule to the shared component commit and update setup/provenance documentation. View-type/app/filter menus and drag ordering remain in the Atomic host; this does not claim full TablePage parity. Validation: all 10 native port browser tests, 5 view/draft unit tests, port typecheck and production build passed. The upstream package passed 16 tests, its typecheck and clean packed-consumer runtime/NodeNext checks; the Data Browser passed its 3 existing tab/menu tests, typecheck and required workspace lint. Desktop/mobile screenshots were captured and shared in the implementation chat. After checking out this branch: run `pnpm setup:table`, then `pnpm install --force --frozen-lockfile` to refresh the local package snapshot.
michielbdejong changed target branch from codex/table-submodule to main 2026-11-06 12:14:01 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
ELFA/database-apps!85
No description provided.